Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some more function instrumentation #2001

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Feb 6, 2024

  • Remove WIP commit before merging

Close #1964
Close #1840

@t-b t-b self-assigned this Feb 6, 2024
@t-b t-b mentioned this pull request Feb 7, 2024
33 tasks
t-b and others added 4 commits February 7, 2024 19:42
The function is called more than 12k times for a single test case like
AFT16. This is very likely due to EnforceIndependentSetting which does
nothing outside of testing.
These are called very often for a single hardware test case.

•ShowTopFunctions(50)
 Function Calls | Sum of called Lines | Procedure                              | Function                        | Line |
----------------|---------------------|----------------------------------------|---------------------------------|------|
 12419          | 173866              | MIES_Utilities.ipf                     | IsConstant                      | 5805 |
 2998           | 80514               | MIES_DAEphys.ipf                       | DAP_ParsePanelControl           | 4172 |
 2900           | 17402               | MIES_MiesUtilities.ipf                 | GetHardwareType                 | 2366 |
 2674           | 16656               | MIES_MiesUtilities.ipf                 | ParseChannelTypeFromString      | 460  |
 2454           | 46594               | MIES_Utilities.ipf                     | RemovePrefix                    | 1613 |
 1956           | 9780                | MIES_MiesUtilities.ipf                 | ChannelTypeToString             | 436  |
 1953           | 34689               | MIES_MiesUtilities.ipf                 | GetPanelControl                 | 486  |
 1872           | 5616                | MIES_WaveDataFolderGetters.ipf         | GetDevicePath                   | 634  |
@t-b t-b force-pushed the bugfix/2001-too-slow-daq-on-main-with-instrumentation branch from 18a20b7 to 02e4541 Compare February 7, 2024 18:42
@t-b t-b marked this pull request as ready for review February 7, 2024 18:42
@t-b t-b requested a review from timjarsky as a code owner February 7, 2024 18:42
@t-b t-b merged commit 66ab13e into main Feb 7, 2024
5 checks passed
@t-b t-b deleted the bugfix/2001-too-slow-daq-on-main-with-instrumentation branch February 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate build failure on main Speedup hardware testing with coverage
2 participants